Fix MultiDict.items().isdisjoint() for C Extensions
#927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #927 +/- ##
==========================================
+ Coverage 96.53% 96.74% +0.20%
==========================================
Files 19 19
Lines 1964 1965 +1
Branches 188 188
==========================================
+ Hits 1896 1901 +5
+ Misses 44 40 -4
Partials 24 24 ☔ View full report in Codecov by Sentry. |
webknjaz
changed the title
MultiDict.items().isdisjoint() for C Extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @webknjaz,
What do these changes do?
These changes fix a mismatch at
views.hthat causesSystemError: null argument to internal routinewhen callingMultiDict.items().isdisjoint().Are there changes in behavior for the user?
MultiDict.items().isdisjoint()will not cause aSystemErrorwhen using C Extensions.Related issue number
Semi-related issue:
multidict/_multidict_base.py#921Checklist
Best regards!